Send FPTI Analytics Events in American Express #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahkoop
commented
Dec 19, 2023
| callback.onAmericanExpressResult(new AmericanExpressResult.Failure(e)); | ||
| } | ||
| } else if (httpError != null) { | ||
| callback.onAmericanExpressResult(new AmericanExpressResult.Failure(httpError)); | ||
| braintreeClient.sendAnalyticsEvent("amex.rewards-balance.error"); | ||
| braintreeClient.sendAnalyticsEvent(AmericanExpressAnalytics.REWARDS_BALANCE_FAILED); |
There was a problem hiding this comment.
I know in other modules we are refactoring to have a single success and error method for callbacks and analytics to confirm we always send analytics with the callback. That seemed a little overkill in this module since there is only one method, but I can add those in if we think it's still beneficial
There was a problem hiding this comment.
We did it on iOS, just for consistency - but whatever you think works on Android 👍
There was a problem hiding this comment.
Updated for consistency too 👍
scannillo
approved these changes
Dec 19, 2023
tdchow
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
AmericanExpressClientto send FPTI analytics eventsAmericanExpressAnalyticsto be a simple object rather than enumChecklist
[ ] Added a changelog entryAuthors