SEPA Direct Debit Single Result Object Pattern #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saperi22
reviewed
Dec 14, 2023
...ctDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitPaymentAuthRequestParams.java
Show resolved
Hide resolved
saperi22
reviewed
Dec 14, 2023
| * if you must continue the SEPA mandate web flow via | ||
| * {@link SEPADirectDebitLauncher#launch(FragmentActivity, SEPADirectDebitPaymentAuthRequest.ReadyToLaunch)} | ||
| */ | ||
| public class SEPADirectDebitPaymentAuthRequestParams { |
There was a problem hiding this comment.
QQ: I see that most of the newly created files are in kotlin. Any reason this is an exception?
There was a problem hiding this comment.
Ah this file isn't actually new it was renamed from the previous SEPADirectDebitPaymentAuthRequest class (which is replaced by the new Kotlin sealed class in this PR). We are slowly migrating to Kotlin, so have been trying to add new files in Kotlin and convert small interfaces, but I didn't refactor this one into Kotlin yet.
saperi22
reviewed
Dec 14, 2023
| */ | ||
| public interface SEPADirectDebitTokenizeCallback { | ||
| public interface SEPADirectDebitInternalTokenizeCallback { |
There was a problem hiding this comment.
What's the significance of the word internal?
We still expose this callback to the merchant, don't we?
There was a problem hiding this comment.
Ah whoops that should have been made package-private - updated!
saperi22
reviewed
Dec 14, 2023
SEPADirectDebit/src/test/java/com/braintreepayments/api/SEPADirectDebitClientUnitTest.java
Outdated
Show resolved
Hide resolved
saperi22
approved these changes
Dec 14, 2023
MaxHastingsPP
approved these changes
Dec 14, 2023
…rectDebitClientUnitTest.java Co-authored-by: saperi22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors