-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronise multiple signal #660
Conversation
toolbox/process/functions/process_synchronise_multiples_signals.m
Outdated
Show resolved
Hide resolved
toolbox/process/functions/process_synchronise_multiples_signals.m
Outdated
Show resolved
Hide resolved
toolbox/process/functions/process_synchronise_multiples_signals.m
Outdated
Show resolved
Hide resolved
@Edouard2laire, yes, please send me a minimal example dataset |
@Edouard2laire, apologies for the delay. there was a misunderstanding, I thought the PR still was on development. I will review it ASAP |
@Edouard2laire, the main change in the process is that files are loaded one by one in memory. Minor changes:
|
toolbox/process/functions/process_synchronise_multiples_signals.m
Outdated
Show resolved
Hide resolved
blocA = zeros(1 , length(tmp_time_a)); | ||
for i_event = 1:size(sEvtSync(iInput).times,2) | ||
i_intra_event = panel_time('GetTimeIndices', tmp_time_a, sEvtSync(iInput).times(i_event) + [0 1]'); | ||
blocA(1,i_intra_event) = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment could be improved by using a Gaussian around the occurrences.
toolbox/process/functions/process_synchronise_multiples_signals.m
Outdated
Show resolved
Hide resolved
toolbox/process/functions/process_synchronise_multiples_signals.m
Outdated
Show resolved
Hide resolved
Thanks a lot for all the changes! Edouard |
Hello. I did few test and it seems to be working. Thanks a lot, Edouard |
@Edouard2laire, great! |
This reverts commit 34c610c.
(Clicked wrong button — you can ignore that) |
For the open tasks:
|
Do you want me to create the PR ? I don't really have any idea on where to start for that implementation.
yes, I agree that it's not really useful. Could be implemented if someone asks. This can be the case if you still want to keep all the signals and don't have the constraint of having all the recordings all the time.
yes, that's true |
I'll start the PR, I need to check some implementation of the raw-file readers |
Hello,
This process aims at aligning multiple signals acquired with different devices but sharing synchronizing events (typically sent to each recording device at the time of the acquisition). This situation can arise easily when recording multimodal data such as EEG - iEEG, EEG - fMRI, fNIRS - fMRI, or EEG - fMRI.
Having the signal synchronised makes making easier to perform multimodal analysis, notably allowing the simultaneous exploration of the different signals. For example, here is a figure I recently presented at a conference, showing how we can understand better what is happening during a seizure by looking at the EEG, fNIRS, and pulse oximeter
What's left to do:
Future work
Here is a list of future things we might consider implementing but that is not required for this PR
Let me know if you want me to send you an example dataset. I can generate a minimum brainstorm database with 2 files to synchronize.
Regards,
Edouard