Compatibility with vedo 2023.5.0 #277
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mega-fix #277 +/- ##
============================================
+ Coverage 67.86% 72.44% +4.57%
============================================
Files 26 26
Lines 1195 1194 -1
============================================
+ Hits 811 865 +54
+ Misses 384 329 -55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good - couple of tiny comments.
As I presume you've seen, the new way to set the color mode (?) can be gleaned from this vedo example - no idea whether we want to/need/should support this (@adamltyson ?)
maybe open a low priority issue so we don't forget? Unless you already had another plan around how to fix this, @IgorTatarnikov ?
| @@ -37,7 +37,7 @@ def ruler(p1, p2, unit_scale=1, units=None, s=50): | |||
| dist = mag(p2 - p1) * unit_scale | |||
| label = precision(dist, 3) + " " + units | |||
| lbl = Text3D(label, pos=midpoint, s=s + 100, justify="center") | |||
| lbl.SetOrientation([0, 0, 180]) | |||
| # lbl.SetOrientation([0, 0, 180]) | |||
There was a problem hiding this comment.
Can this be removed entirely?
There was a problem hiding this comment.
I only left it as a sort of reminder that this used to do something and now it doesn't. The labels aren't in the right place when the add_labels.py example is run so I thought that'll be a good first place to look when we get to fixing it.
| @@ -13,7 +13,7 @@ | |||
| scene = Scene(title="neurons") | |||
|
|
|||
| # Add a neuron from file | |||
| scene.add(Neuron("examples/data/neuron1.swc")) | |||
| scene.add(Neuron("data/neuron1.swc")) | |||
There was a problem hiding this comment.
Do this (and similar) changes in the path imply that the examples have to be run from the examples/ subdirectory? If so, should we make an issue to generalise this using e.g. importlib.resources?
There was a problem hiding this comment.
I can definitely make an issue, most paths need to be cleaned up so they're not as fragile
| @@ -32,7 +32,7 @@ | |||
| "focalPoint": (7718, 4290, -3507), | |||
| "distance": 40610, | |||
| } | |||
| zoom = 1.5 | |||
| zoom = 2.5 | |||
There was a problem hiding this comment.
Should we have a quick comment here to explain this magic number? Presumably it's just something like "Make the screenshot look nicer by zooming up closer"?
There was a problem hiding this comment.
I honestly just took it from here assuming that something changed with how the zoom is calculated in vedo.
| @@ -74,7 +74,8 @@ | |||
|
|
|||
| # 3. create a Volume vedo actor and smooth | |||
| print("Creating volume") | |||
| vol = Volume(transformed_stack, origin=scene.root.origin()).smooth_median() | |||
| vol = Volume(transformed_stack).permute_axes(2, 1, 0) | |||
There was a problem hiding this comment.
Quick comment to explain why the axis permutation is needed?
There was a problem hiding this comment.
I'm planning to move that out of the examples and into the core package, I've left some of the post compatibility changes off of this PR.
No idea tbh |
I'd suggest leaving it out then until a user asks for the functionality, but also happy with an additional |
Before submitting a pull request (PR), please read the contributing guide.
Description
What is this PR
This PR addresses any changed to the API made in vedo 2023.5.0.
Why is this PR needed?
vedo 2023.5.0 was released.
References
#261
How has this PR been tested?
All tests pass locally, all examples apart from
examples/streamlines.pyrun.Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Checklist: