-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonise napari plugin and CLI entry points #193
Conversation
I assume the tests are failing on macOS as those runners have recently been updated to ARM. #191 should fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a sensible minimum for the smoothing parameters? As it stands right now I can't go below -1.0, or -10. Could be worth adding a min=-99.0
or something similar to the appropriate entries of DEFAULT_PARAMETERS
.
Good catch, thanks. I've set these to -99 which seems about right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Should we merge now or wait for #191?
I think merge. This shouldn't (famous last words) affect only one OS. |
Will hold off releasing until #191 though. |
Description
This PR makes sure the outputs of the napari plugin and CLI are equal. Previously, as highlighted in #192 by @AdrianAriasAbreu, there were differences when running the same data in the napari plugin and CLI. +
Why is this PR needed?
The plugin and CLI should be two ways of achieving the same thing.
What does this PR do?
brainglobe_utils.image_io.load.load_any()
(as used by the CLI).References
Closes #192 (I think)
How has this PR been tested?
The same data has been registered with the plugin and CLI and results confirmed to be the same. Existing tests pass.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No, but I noticed some errors in the docs, updated in brainglobe/brainglobe.github.io#170
Checklist: