Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pandas FutureWarning #144

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Fix pandas FutureWarning #144

merged 6 commits into from
Oct 27, 2023

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Oct 26, 2023 •
edited
Loading

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

CI is failing without fix.
Fixes this issue before creating the release of brainreg for brainglobe-v1.

What does this PR do?

Closes #141.

How has this PR been tested?

CI tests pass locally, with tox.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@willGraham01 willGraham01 self-assigned this Oct 26, 2023
@willGraham01 willGraham01 added the bug Something isn't working label Oct 26, 2023
@willGraham01 willGraham01 requested a review from a team October 27, 2023 10:14
alessandrofelder
alessandrofelder previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tests/tests/test_unit/test_misc.py Outdated Show resolved Hide resolved
alessandrofelder
alessandrofelder approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(BTW, if a reviewer comments and approve, they trust you to consider their comments and then merge without needing another look, as (not entirely clearly 😬 ) documented in https://brainglobe.info/developers/index.html#pull-requests

@willGraham01
Copy link
Contributor Author

willGraham01 commented Oct 27, 2023 •
edited
Loading

(BTW, if a reviewer comments and approve, they trust you to consider their comments and then merge without needing another look, as (not entirely clearly 😬 ) documented in https://brainglobe.info/developers/index.html#pull-requests

That's what I thought but I think this repo requires an up-to-date review before merging. (I hit commit suggestion and then it dismissed your review and merging was blocked 😅)
Should I disable this in the repo settings?

And either way, merging now 🚀

@willGraham01 willGraham01 merged commit ab18739 into main Oct 27, 2023
15 checks passed
@willGraham01 willGraham01 deleted the wgraham-141-futurewarning branch October 27, 2023 10:31
@alessandrofelder
Copy link
Member

Ah, I see... I'll update in the repo settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

@adamltyson adamltyson Awaiting requested review from adamltyson

Assignees

@willGraham01 willGraham01

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address pandas FutureWarning
2 participants
@willGraham01 @alessandrofelder