Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll bar to the main widget #68

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Jan 2, 2025

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Unexpected behaviour when widget is larger than the current window size.

What does this PR do?
Wraps the core widget in a QScrollArea allowing scrolling in smaller window sizes.

References

closes #67

How has this PR been tested?

Tested locally by visual inspection on 13" screen.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.09%. Comparing base (6344010) to head (7d486d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   82.00%   82.09%   +0.09%     
==========================================
  Files           9        9              
  Lines         589      592       +3     
==========================================
+ Hits          483      486       +3     
  Misses        106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review January 3, 2025 10:35
@IgorTatarnikov IgorTatarnikov requested a review from a team January 3, 2025 10:35
@adamltyson adamltyson merged commit 539851f into main Jan 3, 2025
23 checks passed
@adamltyson adamltyson deleted the make-widget-scrollable branch January 3, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues on systems with a small screen
2 participants