Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human example script and some other fixes #40

Merged
merged 9 commits into from
May 21, 2024
Merged

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented May 20, 2024

This adds an example using the human atlas because:

  • Now it's got both hemispheres
  • The scale of the atlas makes it trickier to just adapt existing examples

This also fixes a typo and removes some script code in a submodule.

Sort of fixes #14

@adamltyson adamltyson requested a review from a team May 20, 2024 15:28
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c42d3f1) to head (7c5b8d3).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #40   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          5       5           
  Lines        285     282    -3     
=====================================
+ Misses       285     282    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
While we're doing small refactorings around here that will change the API (e.g. you now can't call heatmaps.py as a script anymore), I've opened #41 as a vaguely related small enhancement issue.

@alessandrofelder alessandrofelder merged commit 55a698b into main May 21, 2024
23 checks passed
@alessandrofelder alessandrofelder deleted the human-example branch May 21, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Human brain plots won't work
2 participants