Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a stable automatic module name. #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Define a stable automatic module name. #57

wants to merge 1 commit into from

Commits on Jan 20, 2020

  1. Define a stable automatic module name. 

    @brunchboy would like to modularize the project
https://github.com/Deep-Symmetry/lib-carabiner
but is unable to do so because edn-java does not define an automatic
module name. See
http://branchandbound.net/blog/java/2017/12/automatic-module-name/
for details on why this is necessary. All the other lib-carabiner
dependencies already do this, so as soon as edn-java does so, it will
be possible.

This pull request sets `us.bpsm.edn` as the automatic module name,
which makes sense as it is likely the module name you will use if you
ever decide to modularize this project itself.

Thanks for considering this change.
    James Elliott committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6fa8401 View commit details
    Browse the repository at this point in the history