Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bpmn-js-color-picker dep #145

Merged
merged 3 commits into from
Nov 28, 2023
Merged

feat: add bpmn-js-color-picker dep #145

merged 3 commits into from
Nov 28, 2023

Conversation

tpucci
Copy link
Contributor

@tpucci tpucci commented Nov 9, 2023

Closes #93

  • chore: add bpmn-js-color-picker dep
  • feat: add bpmn-js-color-picker to the pad

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
All committers have signed the CLA.

@tpucci
Copy link
Contributor Author

tpucci commented Nov 9, 2023

I have one issue left, color icons are not displayed by the webview. We need to change them for SVG html tags.

image

Should I open a PR on bpmn-js-color-picker repo ?

EDIT

The bug cause was actually Refused to load the image '<URL>' because it violates the following Content Security Policy directive: "img-src 'self' <URL> blob:".. Fixed it, see below.

@tpucci tpucci marked this pull request as ready for review November 9, 2023 10:43
@tpucci
Copy link
Contributor Author

tpucci commented Nov 10, 2023

Ok, I made it work adding a Content-Security-Policy.

  <meta http-equiv="Content-Security-Policy"
  content="default-src 'none';
  font-src 'self' data:;
+ img-src 'self' data:;
  img-src ${webview.cspSource} blob:;
  style-src ${webview.cspSource};
  script-src 'nonce-${nonce}';">
image

@smbea smbea requested a review from philippfromme November 21, 2023 08:15
@smbea
Copy link

smbea commented Nov 21, 2023

@philippfromme added you as a reviewer since you were weighting in on the issue

@nikku nikku changed the title chore: add bpmn-js-color-picker dep feat: add bpmn-js-color-picker dep Nov 28, 2023
@nikku
Copy link
Member

nikku commented Nov 28, 2023

I think this is a fine addition to the editor. Thank you.

@fake-join fake-join bot merged commit 5ed5163 into bpmn-io:main Nov 28, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
@nikku
Copy link
Member

nikku commented Nov 28, 2023

This will be released with the upcoming v0.19.0 release. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ability to set colors
4 participants