fix: set loop characteristics in a command #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
barmac
force-pushed
the
1960-fix-undo-redo-on-multiinstance
branch
from
d61ecae
to
1f6a25e
Compare
nikku
reviewed
Oct 10, 2023
| if (entry.active) { | ||
| newLoopCharacteristics = undefined; |
nikku
reviewed
Oct 10, 2023
| } | ||
|
|
||
| // update `isSequential` property | ||
| newLoopCharacteristics.set('isSequential', entry.options.isSequential); |
There was a problem hiding this comment.
I'm not sure if we need to copy the full loop characteristics here. As long as we properly undo or redo. What about using Modeling#updateModdleProperty to simply change isSequential to the target value?
There was a problem hiding this comment.
We could if there was only a single object type assigned to loopCharacteristics. However, this can be one of two:
bpmn:MultiInstanceLoopCharacteristicswith propertyisSequential, orbpmn:StandardLoopCharacteristicswithout properties.
Both of them can have Camunda properties which need to be copied if we change the type of the object.
barmac
force-pushed
the
1960-fix-undo-redo-on-multiinstance
branch
from
1f6a25e
to
32dc7a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1960