Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

Moved the cleanup to last #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved the cleanup to last #41

wants to merge 1 commit into from

Conversation

dvestal
Copy link

@dvestal dvestal commented Jan 9, 2015

I noticed that the cleanup script was executed prior to the CM tools being setup/installed. I think for a typical box creation you would actually want that to occur at the end of the script process so that the additional apt artifacts get cleaned up.

@annawake
Copy link
Contributor

The position of the cleanup script is intentional. Apparently the SaltStack and Ansible packages do not properly reference their Python dependencies and the cleanup scripts remove Python out from under these tools. So the cleanup script was moved before the CM tool install.

@dvestal
Copy link
Author

dvestal commented Feb 10, 2015

I have been using this version for about a month now with both the salt and puppet CM tools.

I believe that the issue you are describing comes from the minimize script, not the cleanup script. I will spend a little bit of time today to figure out exactly where the issue comes from to be able to provide details.

@dvestal
Copy link
Author

dvestal commented Feb 10, 2015

I did confirm that the problem you describe, having the dependencies removed, occurs when the "minimize.sh" script is listed after the CM tool installation. That is why I left it before the CM tool installation. The only package removal that occurs in the cleanup script "cleanup.sh" is with "apt-get -y autoremove --purge"

By running "cleanup.sh" at the end you get the cache cleanup, log cleanup and whiteout to occur at the end of the process. The plain boxes generated are consistently 20-30 MB smaller when the "cleanup.sh" script is run last. When I use a custom script in the process the size difference is even greater.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants