Make iteration more robust and give more options in LaplaceNaulin #3061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this old branch. Maybe it's still useful? I have no time to test/update now though, so if it needs work, volunteers needed!
Previously a cycle decreasing the underrelax_factor was triggered if the error increased on an iteration. However sometimes it can be more robust to just continue the iteration with moderate increases in the error - there are cases when decreasing the underrelax_factor never results in a decreasing error, but continuing the main iteration loop for a few steps would. This commit tries to handle this kind of case, with several new parameters which can be adjusted to control how and when underrelax_factor is decreased.
Also documents more options.