Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypre3D Laplacian diagnostics, parallel boundary default fix #3055

Closed
wants to merge 7 commits into from
Closed

Hypre3D Laplacian diagnostics, parallel boundary default fix #3055

wants to merge 7 commits into from

Conversation

bendudson
Copy link
Contributor

  • Hypre3D Laplacian solver now saves diagnostic data if Laplacian::savePerformance() is called.
  • The default parallel boundary condition "parallel_dirichlet" is not implemented. Changed to "parallel_dirichlet_o2".
  • Updated and fixed the elm-pb example: Added phiSolver->savePerformance call, and fixed the data-hypre input.

bendudson and others added 7 commits January 9, 2025 10:44
@bendudson
Hypre3D Laplacian: Save diagnostics using outputVars
31567f9 
Saved to dmp files by the Laplacian savePerformance monitor.
If the savePerformance() method is called to enable outputs,
the mean solver and AMG iterations, and the final residual,
are saved as time-varying scalars.
@bendudson
ParallelTransform: Add missing space in error message
9e765b6
@bendudson
BoundaryFactory: Fix default for parallel boundary regions
90332a8 
Default was "parallel_dirichlet", but no boundary is registered
with that name. Changed to "parallel_dirichlet_o2".
@bendudson
elm-pb example: Fix hypre input, save performance metrics
dc3b020 
Calling `phiSolver->savePerformance(...)` causes performance (e.g. iteration count)
diagnostics to be saved to the output file.

hypre input did have the wrong parallel transform, boundary conditions
that have not been implemented. Now uses hypre3d as the phiSolver.
@bendudson @github-actions
Apply clang-format changes
f46d0a6
@bendudson
OptionsNetCDF: verifyTimesteps, write override base class
e3a4e1e 
Add `override` keyword to squash warning.
@bendudson
tests/integrated: Fix hypre tests
a188682 
- Mesh variable names are case sensitive
- mpirun needs ./ to find executable on some systems
@bendudson
Copy link
Contributor Author

Merged into #3022

@bendudson bendudson closed this Jan 17, 2025
@bendudson bendudson deleted the next-hypre3d-laplace branch January 17, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bendudson