Fixing the phonebook api for json response #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 60.42% 60.41% -0.01%
==========================================
Files 617 617
Lines 13482 13488 +6
==========================================
+ Hits 8146 8149 +3
- Misses 5336 5339 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tykling
requested changes
Jul 31, 2023
|
@tykling done! |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new DectExportJsonView fixing #1380
200 reponse
{"phonebook": [{"number": "1234", "letters": "", "description": "", "activation_code": "7796672559"}, {"number": "8378", "letters": "test", "description": "", "activation_code": "4068685996"}]}403 reponse
{"error": 403, "message": "Permission denied"}