Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

fix lintian errors #8

Closed
berndpfrommer opened this issue Oct 4, 2020 · 2 comments
Closed

fix lintian errors #8

berndpfrommer opened this issue Oct 4, 2020 · 2 comments

Comments

@berndpfrommer
Copy link
Collaborator

Currently the debian packaging scripts (gbp) produce a bunch of lintian errors, see #1
These need to be fixed.
@jlblancoc
Copy link
Member

Looking closer at the lintian errors/warnings, the only relevant one are:

W: libgtsam4: dev-pkg-without-shlib-symlink usr/lib/x86_64-linux-gnu/libmetis-gtsam.so usr/lib/x86_64-linux-gnu/libmetis-gtsam.so
W: libgtsam4: shlib-without-versioned-soname usr/lib/x86_64-linux-gnu/libmetis-gtsam.so libmetis-gtsam.so

But libmetis-gtsam is actually there "temporarily", since we should use the system versions, so... all is better than it looked at first sight!

The other ITP bug warning means we should someday declare the intention to package GTSAM in front of the Debian community by opening an ITP bug, just in case someone has something to say. Then, the first time the package is uploaded to mentors.debian.org and get sponsored by someone, the bug will be marked as closed.

@jlblancoc
Copy link
Member

PS: Further clarification: Fixing borglab/gtsam#292 will fix this one too, that's why I closed it.

berndpfrommer pushed a commit that referenced this issue Oct 17, 2020
@ProfFan
Squashed 'wrap/' changes from 5e1373486..2192b194e
f9e7c7d 
2192b194e Merge pull request #8 from borglab/fix/serialization
3a3461a35 Fix test
ce3d5c35d Fix serialization

git-subtree-dir: wrap
git-subtree-split: 2192b194edc35142e529adcf50ed5e6803d48975
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlblancoc @berndpfrommer