Fix constexpr cmath floor of 1 returning 0 #1232

boostorg · Jan 12, 2025 · adaf1bf · adaf1bf
1 parent c5d3666
commit adaf1bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/include/boost/math/ccmath/floor.hpp b/include/boost/math/ccmath/floor.hpp
@@ -33,7 +33,7 @@ inline constexpr T floor_pos_impl(T arg) noexcept
 
     T result = 1;
 
-    if(result < arg)
+    if(result <= arg)
     {
         while(result < arg)
         {

diff --git a/test/ccmath_floor_test.cpp b/test/ccmath_floor_test.cpp
@@ -32,6 +32,7 @@ constexpr void test()
     static_assert(boost::math::ccmath::isinf(boost::math::ccmath::floor(-std::numeric_limits<T>::infinity())), 
                   "If x is +- inf, it is returned, unmodified");
 
+    static_assert(boost::math::ccmath::floor(T(1.0)) == T(1.0));
     static_assert(boost::math::ccmath::floor(T(2)) == T(2));
     static_assert(boost::math::ccmath::floor(T(2.4)) == T(2));
     static_assert(boost::math::ccmath::floor(T(2.9)) == T(2));