GHA: Allow setting defines, variant, and linkage via matrix #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
===========================================
+ Coverage 95.00% 100.00% +5.00%
===========================================
Files 2 2
Lines 20 22 +2
Branches 10 10
===========================================
+ Hits 19 22 +3
+ Misses 1 0 -1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pass the matrix variables `defines`, `variant`, `link` as `$B2_DEFINES`, `$B2_VARIANT` and `$B2_LINK` If they are not set in the matrix the entry in the `env` dictionary will be empty which results in using the global default value if any or not defining it. I.e. an empty value has no effect and we can set it even if the matrix key is not set.
Flamefire
force-pushed
the
Flamefire-patch-1
branch
from
1c82028 to
a4f3878
Compare
Flamefire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.