Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make apt-get calls consistent #253

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Make apt-get calls consistent #253

merged 3 commits into from
Jan 24, 2025

Conversation

Flamefire
Copy link
Collaborator

  • Don't install packages implicitely
  • Make quiet(er)
  • Use retries

- Don't install packages implicitely
- Make quiet(er)
- Use retries
@Flamefire Flamefire marked this pull request as draft December 19, 2024 13:08
@Flamefire Flamefire marked this pull request as ready for review December 19, 2024 13:18
Required as this is not automatically pulled in anymore
@Flamefire
Copy link
Collaborator Author

@sdarwin I've seen some Boost repos already using this, so I figured it makes sense to make it universally used. Can you see any potential issues with this?

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (85ed0b4) to head (6cb53dd).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #253      +/-   ##
===========================================
+ Coverage   95.00%   100.00%   +5.00%     
===========================================
  Files           2         2              
  Lines          20        22       +2     
  Branches       10        10              
===========================================
+ Hits           19        22       +3     
+ Misses          1         0       -1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ed0b4...6cb53dd. Read the comment docs.

@sdarwin
Copy link
Collaborator

sdarwin commented Jan 23, 2025

ci/codecov.sh is being used by:

  • CI jobs to run codecov
  • Customized lcov reports

I am not certain if the modifications "--no-install-suggests --no-install-recommends" will affect those jobs. In terms of customized lcov/gcovr jobs, those scripts are also installing Perl packages, which means it wouldn't be problematic to adjust those scripts to proactively install 'recommends' and 'suggests' if necessary.
As far as codecov itself, if you have tested it in boost-ci and that is still working, OK.

Copy link
Collaborator

@sdarwin sdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see other comments. Should be alright.

@Flamefire Flamefire merged commit 889211b into master Jan 24, 2025
67 checks passed
@Flamefire Flamefire deleted the apt branch January 24, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants