-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make apt-get calls consistent #253
Conversation
Flamefire
commented
Dec 19, 2024
- Don't install packages implicitely
- Make quiet(er)
- Use retries
- Don't install packages implicitely - Make quiet(er) - Use retries
Required as this is not automatically pulled in anymore
@sdarwin I've seen some Boost repos already using this, so I figured it makes sense to make it universally used. Can you see any potential issues with this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
===========================================
+ Coverage 95.00% 100.00% +5.00%
===========================================
Files 2 2
Lines 20 22 +2
Branches 10 10
===========================================
+ Hits 19 22 +3
+ Misses 1 0 -1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ci/codecov.sh is being used by:
I am not certain if the modifications "--no-install-suggests --no-install-recommends" will affect those jobs. In terms of customized lcov/gcovr jobs, those scripts are also installing Perl packages, which means it wouldn't be problematic to adjust those scripts to proactively install 'recommends' and 'suggests' if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see other comments. Should be alright.