Refactor/android/week6 day1 전체적인 리팩토링, 더블 클릭 방지, 다크 모드 간단 대응 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-chanmin
approved these changes
Dec 13, 2023
| } | ||
|
|
||
| private fun requestChangeFollowStatus() { | ||
| clickEvent.setClickEvent(viewModelScope, 2000L) { userStatus -> |
There was a problem hiding this comment.
저희 setClickEvent 할 때 duration으로 THROTTLE_DURATION 값으로 주고 있는데 여기서는 2000L으로 특별히 설정하신 이유가 있나용?
There was a problem hiding this comment.
기본적으로 팔로우 클릭 후 다시 상태들을 업데이트 하는데 fetch 하기 전에 1초가 끝나는 경우가 있어서 여유롭게 2초로 막아놨습니다!!
Comment on lines
+66
to
+74
| uiScope: CoroutineScope, | ||
| windowDuration: Long = THROTTLE_DURATION, | ||
| onClick: suspend (value: T) -> Unit | ||
| ) { | ||
| throttleFirst(windowDuration) | ||
| .onEach { onClick.invoke(it) } | ||
| .launchIn(uiScope) | ||
| } |
There was a problem hiding this comment.
ViewModel에서 sharedFlow를 통해서 throttleFirst 일반화한 것 좋은 것 같습니다!
클릭 이벤트마다 sharedFlow를 viewModel에 가지고 있어야 하는데 이 방법에 대해서 다같이 이야기 해보면 좋을 것 같네용 👍👍
Comment on lines
+2
to
+29
| <resources> | ||
| <color name="black">#FFFFFFFF</color> | ||
| <color name="white">#FF000000</color> | ||
| <color name="transparent">#00000000</color> | ||
|
|
||
| <color name="event_color_red">#FF6565</color> | ||
| <color name="event_color_orange">#FFC165</color> | ||
| <color name="event_color_green">#7BFF65</color> | ||
| <color name="event_color_blue">#65A3FF</color> | ||
| <color name="event_color_purple">#D765FF</color> | ||
| <color name="event_color_checked">#6750A4</color> | ||
|
|
||
| <color name="event_color_warning">#B11212</color> | ||
| <color name="blue">#FF0000FF</color> | ||
| <color name="red">#FFFF0000</color> | ||
| <color name="green">#4DA430</color> | ||
| <color name="calendar_background_purple">#E8DEF8</color> | ||
| <color name="background_splash">#FF7374E2</color> | ||
|
|
||
| <color name="grey1">#4F4F4F</color> | ||
| <color name="grey2">#828282</color> | ||
| <color name="grey3">#E0E0E0</color> | ||
| <color name="grey4">#F5F5F7</color> | ||
| <color name="grey5">#30828282</color> | ||
|
|
||
| <color name="notification_highlight">#FFFBE4</color> | ||
|
|
||
| <color name="loading_background">#30000000</color> |
There was a problem hiding this comment.
네이밍에 대해 좀 더 같이 고민하고 지으면 좋을 것 같애요!!
There was a problem hiding this comment.
onSurface같은 이름으로 바꿔야 할 것 같아요
LeeHaiLim
approved these changes
Dec 14, 2023
Comment on lines
+66
to
+74
| uiScope: CoroutineScope, | ||
| windowDuration: Long = THROTTLE_DURATION, | ||
| onClick: suspend (value: T) -> Unit | ||
| ) { | ||
| throttleFirst(windowDuration) | ||
| .onEach { onClick.invoke(it) } | ||
| .launchIn(uiScope) | ||
| } |
Comment on lines
+2
to
+29
| <resources> | ||
| <color name="black">#FFFFFFFF</color> | ||
| <color name="white">#FF000000</color> | ||
| <color name="transparent">#00000000</color> | ||
|
|
||
| <color name="event_color_red">#FF6565</color> | ||
| <color name="event_color_orange">#FFC165</color> | ||
| <color name="event_color_green">#7BFF65</color> | ||
| <color name="event_color_blue">#65A3FF</color> | ||
| <color name="event_color_purple">#D765FF</color> | ||
| <color name="event_color_checked">#6750A4</color> | ||
|
|
||
| <color name="event_color_warning">#B11212</color> | ||
| <color name="blue">#FF0000FF</color> | ||
| <color name="red">#FFFF0000</color> | ||
| <color name="green">#4DA430</color> | ||
| <color name="calendar_background_purple">#E8DEF8</color> | ||
| <color name="background_splash">#FF7374E2</color> | ||
|
|
||
| <color name="grey1">#4F4F4F</color> | ||
| <color name="grey2">#828282</color> | ||
| <color name="grey3">#E0E0E0</color> | ||
| <color name="grey4">#F5F5F7</color> | ||
| <color name="grey5">#30828282</color> | ||
|
|
||
| <color name="notification_highlight">#FFFBE4</color> | ||
|
|
||
| <color name="loading_background">#30000000</color> |
There was a problem hiding this comment.
onSurface같은 이름으로 바꿔야 할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
설명
구현사진