Refactor/android/double click: 다중 클릭 방지 개선 및 UI, Notification 개선 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agfalcon
reviewed
Dec 13, 2023
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): FollowViewHolder { | ||
| return FollowViewHolder.from(parent) | ||
| return FollowViewHolder.from(parent, actionType, userClickListener, eventId) |
There was a problem hiding this comment.
뷰홀더 생성 시 인자 넣어주는 것 좋습니다!!
agfalcon
reviewed
Dec 13, 2023
| @@ -51,14 +53,11 @@ class AddEventActivity : BaseActivity<ActivityAddEventBinding>(R.layout.activity | |||
|
|
|||
| private fun setTopAppBar() { | |||
| with(binding.topAppBar) { | |||
| setOnMenuItemClickListener { menuItem -> | |||
| when (menuItem.itemId) { | |||
| setMenuClickEvent(lifecycleScope) { menuItemId -> | |||
There was a problem hiding this comment.
menu click에 대한 더블 클릭을 구현하셨네요!!! 대단합니다..
agfalcon
reviewed
Dec 13, 2023
| emitExceptionEvent(it, R.string.notification_delete_fail) | ||
| }.collectLatest { | ||
| fetchFollowNotificationList() | ||
| if (_followNotificationList.value.isNotEmpty()) { |
agfalcon
reviewed
Dec 13, 2023
Comment on lines
+22
to
+29
| fun MaterialToolbar.menuClicks(): Flow<Int> = callbackFlow { | ||
| setOnMenuItemClickListener { menuItem -> | ||
| this.trySend(menuItem.itemId) | ||
| true | ||
| } | ||
| awaitClose { setOnMenuItemClickListener(null) } | ||
| } | ||
|
|
There was a problem hiding this comment.
진짜 고수시네요... 저도 써먹겠습니다 ㅎㅎ
agfalcon
previously approved these changes
Dec 13, 2023
LeeHaiLim
previously approved these changes
Dec 13, 2023
| @@ -51,14 +53,11 @@ class AddEventActivity : BaseActivity<ActivityAddEventBinding>(R.layout.activity | |||
|
|
|||
| private fun setTopAppBar() { | |||
| with(binding.topAppBar) { | |||
| setOnMenuItemClickListener { menuItem -> | |||
| when (menuItem.itemId) { | |||
| setMenuClickEvent(lifecycleScope) { menuItemId -> | |||
agfalcon
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
설명
ClickEventUtil에 추가했습니다.