Svgo v2 #329
Closed
Svgo v2 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aissaoui-Ahmed
force-pushed
the
svgo-v2
branch
from
9cc956e to
3802f2c
Compare
Aissaoui-Ahmed
force-pushed
the
svgo-v2
branch
from
3802f2c to
5606312
Compare
TrySound
reviewed
Dec 20, 2021
|
This pull request introduces 1 alert when merging 3808f70 into 32c796d - view on LGTM.com new alerts:
|
TrySound
reviewed
Dec 23, 2021
TrySound
reviewed
Dec 23, 2021
TrySound
reviewed
Dec 23, 2021
packages/react-svg-core/src/index.ts
Outdated
| // SVGO Optimize | ||
| export function optimize(opts: any = {}): (content: string) => Promise<string> { | ||
| export function optimize(opts: any = {}) { | ||
| opts = validateAndFix(opts); |
There was a problem hiding this comment.
Config format is different now. So validateAndFix might need to be changed as well.
Aissaoui-Ahmed
force-pushed
the
svgo-v2
branch
from
3808f70 to
8e63536
Compare
|
This pull request introduces 1 alert when merging 8e63536 into 32c796d - view on LGTM.com new alerts:
|
Aissaoui-Ahmed
force-pushed
the
svgo-v2
branch
from
8e63536 to
e06f063
Compare
|
@boopathi can you review this, please? We use your loader and it fails vulnerability check every build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #307
NodeJS releases status and END-OF-LIFE
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=10.13.0". Got "8.17.0"
https://github.com/svg/svgo/blob/b37d90e12a87312bba87a6c52780884e6e595e23/package.json#L52-L54
Travis build
https://app.travis-ci.com/github/boopathi/react-svg-loader/jobs/550900558