forked from cutenode/good-first-issue
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: handle ENOTFOUND and ask users to report all other errors; closes
cutenode#78 This PR will ask users to report unhandled rejections or uncaught exceptions to the project issue tracker. - added a test to check this is working - added dev dep [execa](https://npm.im/execa) for said test - added [buggin](https://npm.im/buggin) unexpected error output
- Loading branch information
Showing
3 changed files
with
29 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,9 +20,9 @@ | |
], | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/bnb/good-first-issue.git" | ||
"url": "https://github.com/cutenode/good-first-issue.git" | ||
}, | ||
"homepage": "https://github.com/bnb/good-first-issue", | ||
"homepage": "https://github.com/cutenode/good-first-issue", | ||
"keywords": [ | ||
"cli", | ||
"node-cli", | ||
|
@@ -43,21 +43,23 @@ | |
"node": ">=8.0.0" | ||
}, | ||
"bugs": { | ||
"url": "https://github.com/bnb/good-first-issue/issues", | ||
"url": "https://github.com/cutenode/good-first-issue/issues", | ||
"email": "[email protected]" | ||
}, | ||
"contributors": [ | ||
"Dhruv Jain <[email protected]> (https://maddhruv.github.io)" | ||
], | ||
"dependencies": { | ||
"boxen": "^3.0.0", | ||
"buggin": "^0.1.6", | ||
"chalk": "^2.4.1", | ||
"commander": "^2.19.0", | ||
"inquirer": "^6.2.0", | ||
"libgfi": "^1.0.2", | ||
"open": "^6.4.0" | ||
}, | ||
"devDependencies": { | ||
"execa": "^3.3.0", | ||
"jest": "^23.6.0", | ||
"strip-ansi": "^5.0.0", | ||
"standard": "^14.0.0" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
const execa = require('execa') | ||
|
||
const BIN_PATH = require.resolve('../bin/good-first-issue.js') | ||
|
||
test('should display link to report bug if project not found', async () => { | ||
return expect( | ||
execa(process.execPath, [ | ||
BIN_PATH, | ||
'marvin-k-mooney/would-you-please-go-now' | ||
]) | ||
) | ||
.resolves.toMatchObject({stderr: /The following unhandled rejection is likely a bug in good-first-issue/}) | ||
}); |