Ready for release

debian/changelog

@@ -1,3 +1,14 @@
+howdy (2.5.1) xenial; urgency=medium
+
+  * Removed dismiss_lockscreen as it could lock users out of their system (thanks @ujjwalbe, @ju916 and many others!)
+  * Added option to disable howdy when the laptop lid is closed (thanks @accek!)
+  * Added automatic fallback to default frame color palette (thanks @Ethiarpus!)
+  * Added manual exposure setting (thanks @accek!)
+  * Fixed test command ignoring dark frame threshold (thanks @eduncan911!)
+  * Fixed import error in v4l2 recorder (thanks @timwelch!)
+
+ -- boltgolt <[email protected]>  Fri, 29 Mar 2019 23:02:21 +0100
+
 howdy (2.5.0) xenial; urgency=medium
 
   * Added FFmpeg and v4l2 recorders (thanks @timwelch!)

src/cli/test.py

@@ -121,7 +121,6 @@ def print_text(line_number, text):
 			print("\nUnknown camera, please check your 'device_path' config value.\n")
 			raise
 
-		frame = cv2.cvtColor(frame, cv2.COLOR_BGR2GRAY)
 		frame = clahe.apply(frame)
 		# Make a frame to put overlays in
 		overlay = frame.copy()

src/pam.py

@@ -18,29 +18,29 @@ def doAuth(pamh):
 	"""Starts authentication in a seperate process"""
 
 	# Abort is Howdy is disabled
-	if config.getboolean("core", "disabled", fallback=False):
+	if config.getboolean("core", "disabled"):
 		sys.exit(0)
 
 	# Abort if we're in a remote SSH env
-	if config.getboolean("core", "ignore_ssh", fallback=True):
+	if config.getboolean("core", "ignore_ssh"):
 		if "SSH_CONNECTION" in os.environ or "SSH_CLIENT" in os.environ or "SSHD_OPTS" in os.environ:
 			sys.exit(0)
 
 	# Abort if lid is closed
-	if config.getboolean("core", "ignore_closed_lid", fallback=True):
+	if config.getboolean("core", "ignore_closed_lid"):
 		if any("closed" in open(f).read() for f in glob.glob("/proc/acpi/button/lid/*/state")):
 			sys.exit(0)
 
 	# Alert the user that we are doing face detection
-	if config.getboolean("core", "detection_notice", fallback=False):
+	if config.getboolean("core", "detection_notice"):
 		pamh.conversation(pamh.Message(pamh.PAM_TEXT_INFO, "Attempting face detection"))
 
 	# Run compare as python3 subprocess to circumvent python version and import issues
 	status = subprocess.call(["/usr/bin/python3", os.path.dirname(os.path.abspath(__file__)) + "/compare.py", pamh.get_user()])
 
 	# Status 10 means we couldn't find any face models
 	if status == 10:
-		if not config.getboolean("core", "suppress_unknown", fallback=False):
+		if not config.getboolean("core", "suppress_unknown"):
 			pamh.conversation(pamh.Message(pamh.PAM_ERROR_MSG, "No face model known"))
 		return pamh.PAM_USER_UNKNOWN
 	# Status 11 means we exceded the maximum retry count
@@ -53,7 +53,7 @@ def doAuth(pamh):
 	# Status 0 is a successful exit
 	elif status == 0:
 		# Show the success message if it isn't suppressed
-		if not config.getboolean("core", "no_confirmation", fallback=False):
+		if not config.getboolean("core", "no_confirmation"):
 			pamh.conversation(pamh.Message(pamh.PAM_TEXT_INFO, "Identified face as " + pamh.get_user()))
 
 		return pamh.PAM_SUCCESS