[CHK-7187] Fix Apple Pay Race Condition #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boldjoshshea
requested review from
davemacaulay,
kshorten42,
JosephLeedy and
nicolenorman
as code owners
boldjoshshea
force-pushed
the
CHK-7187
branch
from
9d3b2f3 to
4641465
Compare
JosephLeedy
changed the title
JosephLeedy
approved these changes
Jan 10, 2025
| @@ -24,6 +24,7 @@ define([ | |||
| response = JSON.parse(response); | |||
| window.checkoutConfig.quoteData.entity_id = response.quoteId; | |||
| window.checkoutConfig.quoteItemData = response.quoteItemData; | |||
| return; | |||
There was a problem hiding this comment.
Is this statement necessary? No additional logic runs after the try/catch block.
There was a problem hiding this comment.
its possible its not necessary, I added it to have an explicit return just for promise resolution. I'll look into removing it in the cleanup task I've got out
davemacaulay
approved these changes
Jan 10, 2025
nicolenorman
approved these changes
Jan 10, 2025
boldjoshshea
force-pushed
the
CHK-7187
branch
3 times, most recently
from
4b4b915 to
4e7611f
Compare
JosephLeedy
approved these changes
Jan 13, 2025
boldjoshshea
force-pushed
the
CHK-7187
branch
from
8bdacc2 to
a6c146f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to sequentialize on update and fix shipping address not set issue for Apple Pay.
Fixes CHK-7187