fix: bug in profit calculation #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I strongly agree with you, but I suggest using work.state.GetBalance(consensus.SystemAddress) as profit instead of Iterative calculation |
|
I agree that using SystemAddress's balance to calculate bid profit is more appropriate. However, when simulating a bundle, it is still necessary to correctly calculate the tx gas fee in order to get ethSentToSystem. Additionally, bundleGasFee is the sum of txGasFees, which also affects the sorting of bundles. |
irrun
changed the title
|
will merge, many thanks @ohmyfinger |
irrun
added a commit
that referenced
this pull request
Jul 4, 2024
fix: bug in profit calculation (#35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the worker uses GasPrice to calculate profit when committing a transaction. This method has issues when calculating EIP1559-type transactions. Refer to
bsc-builder/core/state_transition.go
Line 464 in b0668a8
When calculating blob-type transactions, the blob fee needs to be included.