Merge pull request #52 from bnb-chain/feat-packduration

feat: logging packing duration
bnb-chain · Oct 12, 2024 · f19a025 · f19a025
2 parents 2c306c2 + e21985a
commit f19a025
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/miner/bidder.go b/miner/bidder.go
@@ -278,7 +278,8 @@ func (b *Bidder) bid(work *environment) {
 	_, err := cli.SendBid(context.Background(), bidArgs)
 	if err != nil {
 		b.deleteBestWork(work)
-		log.Error("Bidder: bidding failed", "err", err, "number", work.header.Number, "txcount", len(work.txs), "unrevertible", len(work.UnRevertible))
+		log.Error("Bidder: bidding failed", "err", err, "number", work.header.Number, "txcount", len(work.txs),
+			"unrevertible", len(work.UnRevertible), "packing_duration", work.duration.Milliseconds())
 
 		var bidErr rpc.Error
 		ok := errors.As(err, &bidErr)
@@ -290,7 +291,8 @@ func (b *Bidder) bid(work *environment) {
 	}
 
 	b.deleteBestWork(work)
-	log.Info("Bidder: bidding success", "number", work.header.Number, "txs", len(work.txs))
+	log.Info("Bidder: bidding success", "number", work.header.Number, "txs", len(work.txs),
+		"packing_duration", work.duration.Milliseconds())
 }
 
 // isBestWork returns the work is better than the current best work

diff --git a/miner/worker.go b/miner/worker.go
@@ -99,6 +99,7 @@ type environment struct {
 
 	profit       *big.Int // block gas fee + BNBSentToSystem
 	UnRevertible []common.Hash
+	duration     time.Duration
 }
 
 // copy creates a deep copy of environment.
@@ -1311,6 +1312,7 @@ LOOP:
 		fillStart := time.Now()
 		err = w.fillTransactionsAndBundles(interruptCh, work, stopTimer)
 		fillDuration := time.Since(fillStart)
+		work.duration = fillDuration
 		switch {
 		case errors.Is(err, errBlockInterruptedByNewHead):
 			// work.discard()