Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address warnings in tests #842

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Address warnings in tests #842

merged 9 commits into from
Jan 10, 2025

Conversation

danielballan
Copy link
Member

@danielballan danielballan commented Jan 10, 2025 •
edited
Loading

Various DeprecationWarnings and others have crept up.

  • datetime.utcnow() (naive) -> datetime.now(UTC) (localized), and any comparisons with the result of this also need to be localized
  • sparse.COO wants true numpy arrays, not Python lists.
  • pandas removed delim_whitespace.
  • TemplateResponse changed around its signature.
  • FileResponse no longer accepts method parameter (it's implicitly always GET).

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

@tacaswell tacaswell merged commit 6314f1d into bluesky:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielballan @tacaswell