Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm #827

Merged
merged 20 commits into from
Jan 9, 2025
Merged

Add helm #827

merged 20 commits into from
Jan 9, 2025

Conversation

DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Dec 12, 2024 •
edited
Loading

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

Closes #595

danielballan
danielballan reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Two quick comments.

helm/tiled/values.yaml Show resolved Hide resolved
helm/tiled/values.yaml Outdated Show resolved Hide resolved
@DiamondJoseph DiamondJoseph marked this pull request as ready for review December 16, 2024 09:57
@DiamondJoseph
Copy link
Contributor Author

To test this out, since the github action has not yet been run and the chart published, add your SealedSecret as secret.yaml in helm/tiled/templates/. Then run helm upgrade --install tiled helm/tiled/ from the root of the repository.

@danielballan
Copy link
Member

Thanks for contributing this!

@danielballan danielballan merged commit 8b14aa8 into main Jan 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielballan danielballan danielballan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart
2 participants
@DiamondJoseph @danielballan