Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route original timestamps without converting to durations #3839

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 7, 2024

This improves timestamp prevision.

@aler9 aler9 changed the title route timestamps in original clock rate, without convering them to durations route timestamps with original clock rate, without convering them to durations Oct 7, 2024
@aler9 aler9 changed the title route timestamps with original clock rate, without convering them to durations route timestamps with original clock rate, without converting them to durations Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 27.46667% with 272 lines in your changes missing coverage. Please review.

Project coverage is 55.85%. Comparing base (54c0737) to head (2a4a3c4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/hls/from_stream.go 7.01% 53 Missing ⚠️
internal/protocols/mpegts/from_stream.go 6.12% 46 Missing ⚠️
internal/protocols/hls/to_stream.go 0.00% 42 Missing ⚠️
internal/recorder/format_mpegts.go 60.00% 28 Missing ⚠️
internal/protocols/rtmp/from_stream.go 3.57% 27 Missing ⚠️
internal/protocols/mpegts/to_stream.go 4.00% 24 Missing ⚠️
internal/protocols/rtmp/to_stream.go 0.00% 14 Missing ⚠️
internal/recorder/format_fmp4.go 60.86% 9 Missing ⚠️
internal/formatprocessor/ac3.go 44.44% 4 Missing and 1 partial ⚠️
internal/staticsources/rpicamera/source.go 0.00% 5 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3839      +/-   ##
==========================================
- Coverage   56.01%   55.85%   -0.17%     
==========================================
  Files         194      194              
  Lines       19479    19557      +78     
==========================================
+ Hits        10911    10923      +12     
- Misses       7731     7797      +66     
  Partials      837      837              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 changed the title route timestamps with original clock rate, without converting them to durations route original timestamps without converting to durations Oct 7, 2024
@aler9 aler9 merged commit 23002d9 into main Oct 7, 2024
6 of 8 checks passed
@aler9 aler9 deleted the feature/hls branch October 7, 2024 15:59
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue is mentioned in release v1.9.2 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant