webrtc: fix connection timeout when webrtcAdditionalHosts is filled with existing IP #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3835 +/- ##
==========================================
+ Coverage 56.02% 56.03% +0.01%
==========================================
Files 194 194
Lines 19479 19479
==========================================
+ Hits 10914 10916 +2
+ Misses 7728 7726 -2
Partials 837 837 ☔ View full report in Codecov by Sentry. |
…ith existing IP When an IP in webrtcAdditionalHosts is already present in the candidate list because webrtcIPsFromInterfaces is set to true (default), peer connection fails to establish. This is fixed.
|
This issue is mentioned in release v1.9.2 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IP in webrtcAdditionalHosts is already present in the candidate list because webrtcIPsFromInterfaces is set to true (default), peer connection fails to establish. This is fixed.