Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support using JWT in Authorization header with API, Metrics, PProf (#3630) #3795

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 22, 2024

Fixes #3630

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 62.26415% with 40 lines in your changes missing coverage. Please review.

Project coverage is 56.01%. Comparing base (4b9d3ce) to head (075d4de).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/servers/webrtc/http_server.go 51.85% 12 Missing and 1 partial ⚠️
internal/auth/manager.go 81.25% 5 Missing and 1 partial ⚠️
internal/metrics/metrics.go 0.00% 4 Missing ⚠️
internal/pprof/pprof.go 0.00% 4 Missing ⚠️
internal/playback/server.go 57.14% 3 Missing ⚠️
internal/servers/hls/http_server.go 71.42% 2 Missing ⚠️
internal/servers/rtmp/conn.go 0.00% 2 Missing ⚠️
internal/servers/rtsp/session.go 0.00% 2 Missing ⚠️
internal/servers/srt/conn.go 0.00% 2 Missing ⚠️
internal/api/api.go 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3795      +/-   ##
==========================================
- Coverage   56.04%   56.01%   -0.04%     
==========================================
  Files         194      194              
  Lines       19523    19472      -51     
==========================================
- Hits        10942    10907      -35     
+ Misses       7743     7728      -15     
+ Partials      838      837       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 534b637 into main Oct 5, 2024
7 of 8 checks passed
@aler9 aler9 deleted the feature/auth-bearer branch October 5, 2024 19:15
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue is mentioned in release v1.9.2 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API, metrics, pprof: JWT Auth only works with jwt in Query not in Header
1 participant