Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Favor use of spies vs. done callback #269

Merged
merged 1 commit into from
Oct 13, 2023
Merged

refactor: Favor use of spies vs. done callback #269

merged 1 commit into from
Oct 13, 2023

Commits on Oct 2, 2023

  1. refactor: Favor use of spies vs. done callback 

    Replaced uses of done callback with async tests and sinon spies for verifing results.  Solves with the done callback where assertions would prevent done from being called and the test would report a timeout error vs the proper test failure.
    @jrassa
    jrassa committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    51b320f View commit details
    Browse the repository at this point in the history