Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add WC validation for props, add prop to handle MetaMask usage through WC, Bump Coinbase sdk version #1822

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Fix: Add WC validation for props, add prop to handle MetaMask usage through WC, Bump Coinbase sdk version #1822

merged 9 commits into from
Jul 10, 2023

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Jul 10, 2023 •
edited
Loading

Description

Add WC validation for props and add additional prop to handle MetaMask usage through WC
Also add explore url to docs to allow connecting MetaMask mobile through WalletConnect
Bump coinbase wallet SDK version for bug fixes

Closes: #1815

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@Adamj1232 Adamj1232 requested a review from leightkt July 10, 2023 16:02
This was referenced Jul 10, 2023
Open
Closed
Closed
@Adamj1232 Adamj1232 changed the title Fix: Add WC validation for props and add additional prop to handle MetaMask usage through WC Fix: Add WC validation for props, add prop to handle MetaMask usage through WC, Bump Coinbase sdk version Jul 10, 2023
@socket-security
Copy link

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
dotenv 16.3.1 environment +0 71.6 kB motdotla
@coinbase/wallet-sdk 3.6.0...3.7.1 None +0/-4 405 kB jungho.bang

@Adamj1232 Adamj1232 merged commit 7cc952f into develop Jul 10, 2023
2 checks passed
@Adamj1232 Adamj1232 deleted the fix/WC_validation branch July 10, 2023 16:55
This was referenced Jul 10, 2023
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leightkt leightkt leightkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Walletconnect not working with Metamask mobile app
2 participants
@Adamj1232 @leightkt