-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Fordefi wallet #1820
feat: add Fordefi wallet #1820
Conversation
Thanks for the PR @rony-arnac ! |
@rony-arnac code looks good! Wanted to check on these points again for testing prior to merge:
There are checkboxes in the PR description to check after these have been fully tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @rony-arnac !
* Fix file imports for validation within WC to handle ESM envs (#1833) * Cede store new implementation (#1804) * feat: cede store new implementation * fix: version fix and changing mocked chain to the existing one * feat: cede-store-provider-upgrade-1.0.3 * fix: remove yarn.lock files * Format and yarn it * Revert deletion of yarn.lock from demo --------- Co-authored-by: Mathieu <[email protected]> Co-authored-by: Nikita TEREKHOV <[email protected]> Co-authored-by: Adam Carpenter <[email protected]> * feat: add Fordefi wallet (#1820) * feat: add Fordefi wallet * fix: remove comma * Update packages/injected/src/types.ts --------- Co-authored-by: Adam Carpenter <[email protected]> * Update: Return bn_protect protect btn to update the user's RPC (#1841) * Add back in btn protect btn that was accidentally removed during the AC redesign * Bump core version in docs * Cleanup onboard service in docs * Update frame icon * Bump frame version * Update global version * Remove alpha flags --------- Co-authored-by: clementjuventin <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: Nikita TEREKHOV <[email protected]> Co-authored-by: Rony Fragin <[email protected]>
Description
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)