refactor: sloads and increments in assembly for gas optimization. #179 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @0xneves ready for review |
0xneves
suggested changes
Jan 16, 2024
contracts/Swaplace.sol
Outdated
| unchecked { | ||
| assembly { | ||
| sstore(_totalSwaps.slot, add(sload(_totalSwaps.slot), 1)) | ||
|
|
||
| swapId := sload(_totalSwaps.slot) |
There was a problem hiding this comment.
This won't change gas usage, we can use the previous way for better legibility
contracts/Swaplace.sol
Outdated
| i++; | ||
| assembly { | ||
| i := mload(0x40) | ||
|
|
contracts/Swaplace.sol
Outdated
| i := mload(0x40) | ||
|
|
||
| i := add(i, 1) | ||
|
|
contracts/Swaplace.sol
Outdated
| i++; | ||
| assembly { | ||
| i := mload(0x40) | ||
|
|
contracts/Swaplace.sol
Outdated
| i := mload(0x40) | ||
|
|
||
| i := add(i, 1) | ||
|
|
contracts/Swaplace.sol
Outdated
| @@ -126,6 +140,14 @@ contract Swaplace is SwapFactory, ISwaplace, IERC165 { | |||
| * @dev Getter function for _totalSwaps. | |||
| */ | |||
| function totalSwaps() public view returns (uint256) { | |||
| return _totalSwaps; | |||
| uint256 swapId; | |||
|
|
|||
There was a problem hiding this comment.
totalSwaps is never called on-chain, therefore there is no gas optm., we can keep the original way to preserve legibility
|
Hey @0xneves, done as requested. Ready for review. |
0xneves
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #179