Add USDT as a collateral type. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: RWA007 Monetalis onboarding spell * chore: fix END.cage() tests * chore: fix removing empty lines in the end of files * feat: add tests for conduits setup * Base spell * chore: add more sanity checks * Add Starknet max deposit rise to PE-1084 (makerdao#109) * rise Starknet max deposit * update Starknet test * add comment * `WAD` * Add Teleport feed update to PE-1084 (makerdao#111) * Add Teleport feed update to PE-1084 * Fix test * Add old feed addresses to test * Remove white lines Co-authored-by: Nazzareno Massari <[email protected]> * Update src/Goerli-DssSpell.sol Co-authored-by: Nazzareno <[email protected]> * Update src/Goerli-DssSpell.t.sol Co-authored-by: Nazzareno <[email protected]> * Update src/Goerli-DssSpell.t.sol Co-authored-by: Nazzareno <[email protected]> * chore: fix some comments * chore: fix broken merge * chore: more comments fixes * chore: align error messages in sanity cheks * chore: more aligment fixes * chore: visibility on vars * chore: update address * reset for next spell * remove unused WAD * add 1m draw and bump version to 1.14.2 * fix chainlog version test * chore: update RWA007_DOC ipfs hash * fix message * fix comments * remove 1m draw from spell * chore: add tests for RWA007 lock * chore: add missing gemJoin() to urn interface * fix: update DOC hash * chore: add deployer address * address comments * Update src/Goerli-DssSpell.t.sol Co-authored-by: Julien <[email protected]> * chore: fix pr comments * switch output ordering * added another deployer check * remove the wards check * set the quitTo in the spell * move RWAs to be together * ordering * Update src/Goerli-DssSpellCollateral.sol Co-authored-by: Julien <[email protected]> * use address pip * remove the quitTo as its set below * add interface * Update src/Goerli-DssSpellCollateral.sol Co-authored-by: Julien <[email protected]> * add interface * use DssExecLib instead of changelog directly * whitespace * update sanity checks for more coverage * typos in comments * no need to check SF * more checks * remove unused import * Update src/Goerli-DssSpell.t.sol Co-authored-by: Nazzareno <[email protected]> * Update src/Goerli-DssSpell.t.sol Co-authored-by: Nazzareno <[email protected]> * add spell and timestamp * add archive Co-authored-by: Nazar Duchak <[email protected]> Co-authored-by: Nazzareno Massari <[email protected]> Co-authored-by: Maciej Kamiński <[email protected]> Co-authored-by: olivdb <[email protected]> Co-authored-by: Nazar Duchak <[email protected]> Co-authored-by: Julien <[email protected]>
* chore : port from spells-mainnet * test : add mat comment back
* chore : port from spells-mainnet * chore : clean previous spell * test : add code hash test * test : add buf changes * test : add cusp changes * Added config.sol changes, modified gitignore * Added ilk.hole change tests, global hole test, tip tests * Added comment note for ETH-B discrepancy, removed RWA-007 code from DssSpellCollateral * Added spell action scaffold * Added goerli spell actions, removed comment in config.sol * Remove unused interfaces Co-authored-by: Chris Smith <[email protected]> * Alignment Co-authored-by: Chris Smith <[email protected]> * Address calling alignment Co-authored-by: Chris Smith <[email protected]> * Parameter change alignment Co-authored-by: Chris Smith <[email protected]> * Added comments * Added comments for equivalent DssExecLib functions, commented out a line * Refactored actions to use DssExecLib, reset SpellCollateral file * Added MOMC parameter changes * Changed from decreaseIlkDebtCeiling to setIlkAutoLineDebtCeiling * Updated DssSpellCollateral template to current version * Changed percent rate constant naming * Spacing Co-authored-by: Chris Smith <[email protected]> * Added Chris's changes * Removed DS Store from gitignore * Fixed WSTETH-B duplicate in config.sol, fixed incorrect clip_tail value for it * Added test for YFI-A, skipped CRVV1ETHSTETH-A 'pct' check as we are on Goerli * Re-enabled RENBTC spell action, formatting * Remove old comment for ETH-B clip tail Co-authored-by: Chris Smith <[email protected]> * Remove teleport specific code which was commented out Co-authored-by: Chris Smith <[email protected]> * Splendiferously specific spacing Co-authored-by: Chris Smith <[email protected]> * Remove a space Co-authored-by: Chris Smith <[email protected]> * Remove teleport specific code which was commented out Co-authored-by: Chris Smith <[email protected]> * Added newline at the end of gitignore * Removed Chris's tab * Added deployed spell address and timestamp. Thanks Brian for deploying. * Added archived spell * Added archived spell * Removed double archive Co-authored-by: Arby <[email protected]> Co-authored-by: Arby <[email protected]> Co-authored-by: Chris Smith <[email protected]>
* reset spell to template * reset spell config * Enable autoline for RWA007-A (makerdao#121) * feat: enable autoline for RWA007-A * chore: address PR comments * refactor: reorder collateral management methods * fix: comment on collateral actions * PE-1102: 2022-10-19 Executive GUSD PSM (makerdao#120) * add tests for GUSD change * add GUSD changes to spell actions * remove unneed MILLIONS * fix spacing Co-authored-by: Christopher Mooney <[email protected]> * Update to Bips notation Co-authored-by: Arby <[email protected]> * add deployed spell * add archive * add archive with correct date Co-authored-by: dbkbali <[email protected]> Co-authored-by: Christopher Mooney <[email protected]> Co-authored-by: Arby <[email protected]>
* `hash-exec-copy.sh` * fix error msg Co-authored-by: Arby <[email protected]> * refactoring + sanity checks + fix key filtering * fix default key filtering * rm `case` + refactoring * `url` * more refactoring + url filtering * improve url err msg Co-authored-by: Gonzalo Balabasquer <[email protected]> * simplify Co-authored-by: Arby <[email protected]> Co-authored-by: Gonzalo Balabasquer <[email protected]>
* Add ETHERSCAN_API_KEY check in `deploy.sh` * cleanup
* Cleared PE1102 content * Removed PSMlike interface from tests file, removed deployed spell address and timestamp from config * Removed the aforementioned interface, added action comments and some links * Added rETH onboarding forum post link * First draft * fix bridge legacy address * add link to the l2 spell * feat: add goerli reth spell (makerdao#122) * feat: add goerli reth spell * Apply suggestions from code review Co-authored-by: Amusing Axl <[email protected]> * chore: reflect review comments Co-authored-by: Amusing Axl <[email protected]> * Revert "feat: add goerli reth spell (makerdao#122)" This reverts commit c6156f2. * remove changelog version bump * feat: add goerli reth spell (Re-opens makerdao#122) (makerdao#127) * feat: add goerli reth spell * Apply suggestions from code review Co-authored-by: Amusing Axl <[email protected]> * chore: reflect review comments * chore: address review comments * chore: add internal flag to remaining constants * chore: add editorconfig * Update src/test/config.sol Co-authored-by: Arby <[email protected]> * Update src/test/config.sol Co-authored-by: Arby <[email protected]> * Apply suggestions from code review Co-authored-by: Arby <[email protected]> * fix: remove unnecessary dependencies and fix chainlog version * test: add chainlog and ilkregistry tests Co-authored-by: dbkbali <[email protected]> Co-authored-by: Amusing Axl <[email protected]> Co-authored-by: Arby <[email protected]> * Removed IAM enable code, changed rETH onboarding line to 0 per internal discussion * feat: add updateCollaterals to collateral action template * Moved version bump to the end * Removed Oracle whitelisting comments * chore: reorganize test collateral integrations comments * Updated comments * Changed chip comment in config.sol Co-authored-by: Amusing Axl <[email protected]> * Removed unused variable in starket.t.sol * refactor: reorganize rate declaration * Moved comments after values in the tests file * chore: cleanup collateral onboarding action * Added comment with new bridge source code link * Polished comments in DssSpellCollateral * Added rates example comment to DssSpell.sol * Added PE_08 deployer to addresses_deployers and reformatted file * Fixed PE_08 deployer address * Added new Oracles address to addresses_deployers * Added second oracles address (tentative, requires confirmation) and edited addresses_deployers * Added conditional execution for new starknet bridge setup depending on current bridge closing successfully * cleanup (makerdao#128) * cleanup * Double-check bridge closed * rn collateralAction * Updated template, commented out unused functions * Changed addresses used for starknet parts to inte rnal constants, changed rates example comment * Removed second oracles wallet address test for skipWards, changed address to CES_05 * Re-added skipWards OK for CES_05 * Spacing in address_deployers.sol Co-authored-by: Brian L. McMichael <[email protected]> * Renamed CES_05 to ORACLES_2 and ORACLES to ORACLES_1 * Added deployed spell address and timestamp * Archived spell * Added dai bridge check to reflect changes to mainnet spells repo * Removed 'ONLY ON GOERLI' comment for skipWards helper Co-authored-by: Maciek Kamiński <[email protected]> Co-authored-by: dbkbali <[email protected]> Co-authored-by: Amusing Axl <[email protected]> Co-authored-by: Brian McMichael <[email protected]>
* blankify spell * Starknet Teleport spell (makerdao#112) * Base spell * draft * WIP * make most tests pass * remove unnecessary line * move checkTeleportFW to Goerli-DssSpell.t.base.sol * chore : port from spells-mainnet * chore : clean previous spell * test : add code hash test * test : add buf changes * test : add cusp changes * fix Naz comments * fix testTeleportFW test * remove unused declaration * fix bridge auth, update addresses * remove unused interface * teleport test restored Co-authored-by: Nazzareno Massari <[email protected]> Co-authored-by: Julien Martin <[email protected]> * use forge by default * Add mainnet comments * rm sp * immutable addresses * ceiling constant * test chainlog version * Mainnet PE-1108 changes, Align to starkent deployment * Add MOMC MANA-A changes * Fix chainlog version bump * Handle initial CR comments * Apply suggestions from code review Remove unused interfaces and fix indentations Co-authored-by: Gonzalo Balabasquer <[email protected]> * Use goerli addresses file for STARKNET_CORE testing * identation Co-authored-by: Gonzalo Balabasquer <[email protected]> * Add address * Archive spell Co-authored-by: Brian McMichael <[email protected]> Co-authored-by: Maciej Kamiński <[email protected]> Co-authored-by: Nazzareno Massari <[email protected]> Co-authored-by: Julien Martin <[email protected]> Co-authored-by: rockyfour <[email protected]> Co-authored-by: Gonzalo Balabasquer <[email protected]>
makerdao#134) * Remove code hash check, done correctly in test_bytecode_matches * Move DssSpell bytecode length check to test_bytecode_matches Co-authored-by: rockyfour <[email protected]>
* PE-1117: November Debt Exposure Executive * updated for forum post * forgot MATIC-A * remove old tests * remove chainlog test * don't need this either * comments are bullshit * autoLine.exec() tests * removed needless asserts and tests * forgot to remove prevLine * update autoline test to inflate gap/lines * fix test import and comments * added deployed spell * archive * fix low gas estimate Co-authored-by: Chris Smith <[email protected]>
* feat: MANA-A and RWA007-A param changes * feat: rwa007, rwa008, rwa009 doc change, changelog houskeeping * feat: rwa007 doc changes * chore: update naming in test addresses * chore: bump changelog * feat: set RETH-A autiline * Remove specific spell file for Collaterals * chore: fix PR comments, add oracle doc update check fn to base test * chore: group doc update, add spotter.poke() for RWA007 price bump * chore: add additional check for after price bump * chore: remove MANA-A from spell * chore: revert config for MANA-A * chore: remove unused interface * chore: add RETH-A collatelar integration test * chore: update config to the latest spell exec * chore: fix pr commentys * chore: remove epmpty line * chore: fix clliper test * chore: add draw to oracle price bump tests * chore: add spell deplyoment * chore: archive spell * chore: redo spell archive Co-authored-by: Nazar Duchak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)Checklist
officeHoursmodifier override30 daysunless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deployGoerlietherscanmake spell="0x-deployed-spell-address" cast-spellmake archive-spellormake date="YYYY-MM-DD" archive-spellto make an archive directory and copyGoerli-DssSpell.sol,Goerli-DssSpell.t.sol,Goerli-DssSpell.t.base.sol, andGoerli-DssSpellCollateralOnboarding.solsquash and mergethis PR