Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-62354: Support Cosine Similarity #52

Merged
merged 4 commits into from
Aug 5, 2024
Merged

MB-62354: Support Cosine Similarity #52

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63c7155
MB-62354: Support Cosine Similarity
CascadingRadium Jul 9, 2024
db19daa
resolve comment
CascadingRadium Jul 9, 2024
946e7e9
fix overflow
CascadingRadium Jul 10, 2024
57ae488
code review
CascadingRadium Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions vector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,17 @@ type VectorField interface {
const (
EuclideanDistance = "l2_norm"

// dotProduct(vecA, vecB) = vecA . vecB = |vecA| * |vecB| * cos(theta);
// where, theta is the angle between vecA and vecB
// If vecA and vecB are normalized (unit magnitude), then
// vecA . vecB = cos(theta), which is the cosine similarity.
// Thus, we don't need a separate similarity type for cosine similarity
CosineSimilarity = "dot_product"
InnerProduct = "dot_product"

CosineSimilarity = "cosine"
)

const DefaultSimilarityMetric = EuclideanDistance

// Supported similarity metrics for vector fields
var SupportedSimilarityMetrics = map[string]struct{}{
EuclideanDistance: {},
InnerProduct: {},
CosineSimilarity: {},
}

Expand Down
Loading