This commit addresses the problem of not being able to upload the sam… #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e file twice. Since the value property of the file component does not change, the change event does not fire preventing the user from starting the upload. By adding a click handler on the input, the value is set to an empty string, causing the 'bug' to not happen.
|
|
|
Could i get some feedback on this ? |
|
What is the status on this? I am also still having this issue. I don't know enough about your code to provide a review. |
|
Not much progress, i haven't got any response unfortunately |
|
What's the status of this PR? It's a really important fix! Please do smth. |
osahner
approved these changes
Oct 25, 2019
|
Please merge. The workaround for angular 8 is: <input #fileInput type="file" ngFileSelect ... @ViewChild('fileInput', { static: false })
fileInput: ElementRef;
ngAfterViewInit() {
// https://github.com/bleenco/ngx-uploader/issues/474
this.fileInput.nativeElement.onclick = function() {
this.value = null;
};
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e file twice.
Since the value property of the file component does not change, the change event does not fire preventing the user from starting the upload.
By adding a click handler on the input, the value is set to an empty string, causing the 'bug' to not happen.