Reduce false positives with canary probe #2168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly changes the behavior of the reflected params module. It now requires the check of a canary, along with the target parameter. This is to prevent situations where ALL parameters are reflected to the page. These scenarios are rarely interesting to an attacker.
This also adds the ability to test reflection in ALL parameter types - not just GET as before. Prior to this, all parameter types were tried as GET requests only.
Tests were added for all new functionality.
This PR meets the goals set by #2097, although the approach ended up being somewhat different.