-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate postman workspaces #2124
base: dev
Are you sure you want to change the base?
Validate postman workspaces #2124
Conversation
Will be testing this soon |
@domwhewell-sage the postman API changed to disallow page sizes bigger than 25, so I made a PR to your PR: |
Update postman module for new API changes
Hmm has your account hit the request limit by any chance? This might be a good opportunity to revisit the undocumented (to my knowledge) public API. The reason I didn't go that route in the first place is the output has to be a certain way for trufflehog to parse it correctly. Would be easier now we know what the output needs to look like so we can reconstruct it using the public API instead and some jiggery pokery |
Oh okay, I don't have an account but didn't it work before without an API key? |
It did, but now it requires an API key in order to request the workspaces to validate if their contents are in-scope |
Ah that makes sense. I marked both modules as |
LGTM |
The postman module wasn't validating workspaces before raising
CODE_REPOSITORY
events. This PR moves the code to obtain the workspace from the postman API and validate it into the shared template. That way both modules crawl the workspace.The postman module originally did not require the API key but now I have moved that functionality into the template so they both share postman api keys.
I have added to the postman test aswell so it validates that the out-of-scope workspace does not get raised
Closes #1319