Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overflow 163 inject logging fields #165

Merged
merged 4 commits into from
Jun 18, 2024
Merged

overflow 163 inject logging fields #165

merged 4 commits into from
Jun 18, 2024

Conversation

gabrielseibel1
Copy link
Collaborator

@gabrielseibel1 gabrielseibel1 commented Jun 14, 2024 •
edited
Loading

  • Inject log fields in ctx for grpc logs

Closes #163

@gabrielseibel1 gabrielseibel1 self-assigned this Jun 14, 2024
@gabrielseibel1 gabrielseibel1 marked this pull request as draft June 14, 2024 12:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

Unit Test Results

191 tests  ±0   191 ✔️ ±0   38s ⏱️ +10s
    3 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 5d05ad5. ± Comparison against base commit 445011f.

♻️ This comment has been updated with latest results.

@gabrielseibel1 gabrielseibel1 force-pushed the overflow-163-inject-logging-fields branch from 117c69d to e1b5a6b Compare June 14, 2024 12:12
@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9515856803

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 76.168%
Totals Coverage Status
Change from base Build 8993174337: 0.05%
Covered Lines: 2135
Relevant Lines: 2803
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9515897819

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 76.168%
Totals Coverage Status
Change from base Build 8993174337: 0.05%
Covered Lines: 2135
Relevant Lines: 2803
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9515936999

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 76.143%
Totals Coverage Status
Change from base Build 8993174337: 0.03%
Covered Lines: 2132
Relevant Lines: 2800
💛 - Coveralls

bjartek
bjartek requested changes Jun 14, 2024
View reviewed changes
Copy link
Owner

@bjartek bjartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this to

  • GetTransactionsByBlockID
  • GetOverflowTransactionById (if the above will not inherit)
  • GetTransactionById

state.go Outdated
@@ -532,6 +533,7 @@ func (o *OverflowState) InitializeContracts(ctx context.Context) *OverflowState

// GetAccount takes the account name and returns the state of that account on the given network.
func (o *OverflowState) GetAccount(ctx context.Context, key string) (*flow.Account, error) {
ctx = logging.InjectLogField(ctx, "account_name", key)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add address here as a seperate logging field, i belive it can have value to have both here. the name is totally local to your configuration while the address could be valuable remotely aswell.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll do that, yes

@gabrielseibel1 gabrielseibel1 marked this pull request as ready for review June 14, 2024 12:22
@gabrielseibel1 gabrielseibel1 force-pushed the overflow-163-inject-logging-fields branch from be5d45b to d857c56 Compare June 18, 2024 10:11
@gabrielseibel1 gabrielseibel1 force-pushed the overflow-163-inject-logging-fields branch from d857c56 to 5d05ad5 Compare June 18, 2024 10:13
@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9563163372

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 75.99%
Changes Missing Coverage Covered Lines Changed/Added Lines %
transaction.go 1 3 33.33%
Totals Coverage Status
Change from base Build 9561778888: -0.02%
Covered Lines: 2111
Relevant Lines: 2778
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9563193487

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 75.99%
Changes Missing Coverage Covered Lines Changed/Added Lines %
transaction.go 1 3 33.33%
Totals Coverage Status
Change from base Build 9561778888: -0.02%
Covered Lines: 2111
Relevant Lines: 2778
💛 - Coveralls

@bjartek bjartek merged commit fc43c53 into main Jun 18, 2024
4 of 5 checks passed
@bjartek bjartek deleted the overflow-163-inject-logging-fields branch June 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjartek bjartek bjartek approved these changes

@willsu88 willsu88 Awaiting requested review from willsu88

Assignees

@gabrielseibel1 gabrielseibel1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add blockheight to context
3 participants
@gabrielseibel1 @coveralls @bjartek