Merge pull request #2964 from bitzesty/a11y-radio

Sets from and to variables for error method in RecentFinancialYearQuestion
bitzesty · Jun 14, 2024 · 3903fb3 · 3903fb3
2 parents 4561fe5 + 512dd99
commit 3903fb3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/forms/qae_form_builder/trade_most_recent_financial_year_options_question.rb b/forms/qae_form_builder/trade_most_recent_financial_year_options_question.rb
@@ -1,16 +1,5 @@
 class QaeFormBuilder
   class TradeMostRecentFinancialYearOptionsQuestionValidator < OptionsQuestionValidator
-    def errors
-      result = {}
-
-      date, range = question.get_changeable_date_range
-
-      if date.present? && range.present? && !date.in?(range) && question.year_has_changed?
-        result[question.key] = "You can only change the year if your dates in question D2 range between #{from.decorate.formatted_trigger_date} to #{to.decorate.formatted_trigger_date}."
-      end
-
-      result
-    end
   end
 
   class TradeMostRecentFinancialYearOptionsQuestionBuilder < OptionsQuestionBuilder

diff --git a/spec/fixtures/form_answer_innovation.json b/spec/fixtures/form_answer_innovation.json
@@ -212,5 +212,6 @@
 "head_job_title": "test",
 "head_email": "test",
 "strong_esg_record": "on",
-"major_issues_overcome": "test"
+"major_issues_overcome": "test",
+"most_recent_financial_year": "2024"
 }
diff --git a/spec/fixtures/form_answer_trade.json b/spec/fixtures/form_answer_trade.json
@@ -178,5 +178,6 @@
 "head_job_title": "test",
 "head_email": "test",
 "strong_esg_record": "on",
-"major_issues_overcome": "test"
+"major_issues_overcome": "test",
+"most_recent_financial_year": "2024"
 }