Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL-276 - Update tab styles #13063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

danielleflinn
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/CL-276

๐Ÿ“” Objective

Update the tab component styles to match the new Design System styles:

  • Update top border radius for active and focus states
  • Update focus ring to primary-600
  • Remove active state text underline
  • Update disabled styles

๐Ÿ“ธ Screenshots

Before:
Screenshot 2025-01-24 at 10 59 15โ€ฏAM

After:
Screenshot 2025-01-24 at 10 59 24โ€ฏAM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@danielleflinn danielleflinn requested a review from a team as a code owner January 24, 2025 19:00
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 6b82c2ec-9251-4993-a6eb-3d23ab646ee3

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 75
detailsThe JavaScript file imported in "https://js\.stripe\.com/v3/?advancedFraudSignals=false" in /apps/web/src/app/billing/shared/payment/payment.componen...
Attack Vector
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 75
detailsThe JavaScript file imported in "https://js\.stripe\.com/v3/?advancedFraudSignals=false" in /apps/web/src/app/billing/shared/payment/payment.componen...
Attack Vector

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.25%. Comparing base (dd1047c) to head (b362b30).
Report is 8 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ponents/src/tabs/shared/tab-list-item.directive.ts 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13063      +/-   ##
==========================================
+ Coverage   35.10%   35.25%   +0.15%     
==========================================
  Files        3000     2997       -3     
  Lines       91332    90886     -446     
  Branches    17095    16975     -120     
==========================================
- Hits        32065    32046      -19     
+ Misses      56762    56351     -411     
+ Partials     2505     2489      -16     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant