[CL-475] Use buttons instead of anchors for popup tab navigation #11643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11643 +/- ##
==========================================
+ Coverage 33.24% 33.26% +0.01%
==========================================
Files 2787 2789 +2
Lines 86666 86668 +2
Branches 16513 16506 -7
==========================================
+ Hits 28813 28826 +13
+ Misses 55558 55547 -11
Partials 2295 2295 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
CL-475
📔 Objective
This PR switches the popup tab navigation from anchors to buttons for improved visual accessibility (i.e. no link preview displayed when hovering). We are setting the
role="link"to indicate to assistive technology that these do navigate to a new page. This PR also wraps the navigation options in anavelement and list elements, which was missed when the component was originally created. This improves accessibility for assistive technologies. This PR does not adjust the keyboard navigation for the nav menu.📸 Screenshots
Screen.Recording.2024-10-21.at.3.26.40.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes