[PM-13804] Add new Is-Prerelease header to requests #11605
+53
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trmartin4
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11605 +/- ##
==========================================
+ Coverage 33.20% 33.25% +0.05%
==========================================
Files 2782 2789 +7
Lines 86484 86675 +191
Branches 16484 16507 +23
==========================================
+ Hits 28714 28826 +112
- Misses 55483 55554 +71
- Partials 2287 2295 +8 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
|
💭 What if we don't consider just betas? Is the naming of "prerelease" more appropriate? Do we think these need to be enumerated? |
Addressed with |
|
🤔 I see that there aren't any tests for |
trmartin4
changed the title
dani-garcia
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13804
📔 Objective
We want the ability to control feature flags based on whether the requesting client is a beta build or not.
To provide this context to LaunchDarkly, we must introduce a way for the clients to communicate that they are a beta to the server, where it can be used to build the LaunchDarkly context.
This will be done with an
Is-Prereleaseheader on the request.This PR adds that header to all API requests to our back-end based on whether the client-side
prereleaseBuildflag is enabled.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes