[PM-11721] [BEEEP] Add initial password-protected zip export support #10926
Conversation
|
New Issues
Fixed Issues
|
|
@quexten I love that you continue to push forward with this. Let me know if I can assist, even with just feedback like this: One thing to keep in mind for the sake of automation. A lot user want to use the CLI to create regular backups. Does this new lib work under node ? If it doesn't we'll have to think about how we would be able to support the new format within the CLI. |
quexten
changed the title
|
@djsmith85 I did not test the library under node yet, but it seems to have support for node, deno and bun, going through docs / github issues, so anything that can run js/ts. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## auth/beeep/zip-export #10926 +/- ##
======================================================
Coverage 33.32% 33.32%
======================================================
Files 2787 2787
Lines 86619 86625 +6
Branches 16523 16525 +2
======================================================
+ Hits 28868 28870 +2
- Misses 55446 55449 +3
- Partials 2305 2306 +1 ☔ View full report in Codecov by Sentry. |
|
Ok, @djsmith85 there are a few quirks with using the library in node, (noticed during fixing the jest tests). The blobreader / textreader and writers don't work because they rely on a global If we want to actually use the library for streaming data (not just encryption) for very large zip files (we can on both cli and web), we'd have to take another look, but then again this needs re-thinking about how we present the progress to the user anyways and is a future endeavor. |
|
Branch conflicts need to be resolved. I also note some regressions in code coverage. It looks mainly like a few more unit tests need to be written. |
|
@djasonpenney Was on vacation, apologies for the delayed response. This is waiting for review from the tools team. Once they reviewed, the minor package-lock conflict will be resolved in order not to have too much merge conflict resolution overhead. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11721
📔 Objective
Use the zip.js library instead of jszip, in order to add support for large (>4GB) zip archives, and encrypted exports.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes