BEP-21: document the protocol that's actually implemented by everyone #86
Conversation
jech
changed the title
beps/bep_0021.rst
Outdated
| is a peer that is incomplete without downloading anything more. This | ||
| happens for multi file torrents where users only download some of | ||
| the files. | ||
| This document describes an extension which allows a node to announce that |
There was a problem hiding this comment.
I think of the term "node" to refer to a participant in the DHT, and "peer" as a participant in a bittorrent swarm. I believe this terminology is common among other BEPs as well. In your update you seem to use both "node" and "peer" interchangeably (unless I'm missing some subtlety).
Would it make sense to just use "peer"?
beps/bep_0021.rst
Outdated
| Sender operation | ||
| ---------------- | ||
|
|
||
| Upon connecting to a new peer, if the sending node is a partial peer, it |
There was a problem hiding this comment.
I suppose you would end up with 3 "peer" in this sentence. However, perhaps all uses of "partial peer" should be replaced by "partial seed" (as that's the term that established at the beginning)
beps/bep_0021.rst
Outdated
| @@ -59,7 +121,8 @@ the clients are announcing that they are partial seeds. | |||
| References | |||
| ========== | |||
|
|
|||
| .. _`BEP 0010`: http://www.bittorrent.org/beps/bep_0010.html | |||
| .. [#BEP-10] `BEP 0010`: Extension Protocol. | |||
| http://www.bittorrent.org/beps/bep_0010.html | |||
There was a problem hiding this comment.
this line-break seems gratuitous
|
looks good overall. The previous version did not attempt to describe how clients would use this (at was expected to be inferred). Your update goes so far to say a flag should be maintained for each peer to indicate whether it's a partial seed or not. It still doesn't say what that flag could be used for. The only thing I can think of is to disconnect peers that are partial seeds and we're not interested in any of the pieces they have. That might be worth mentioning. |
|
I think of the term "node" to refer to a participant in the DHT, and "peer" as
a participant in a bittorrent swarm. I believe this terminology is common
among other BEPs as well. In your update you seem to use both "node" and
"peer" interchangeably (unless I'm missing some subtlety).
No, actually I'm using "node" to mean a participant, and "peer" as the guy
I'm speaking to. I.e. you and I are both nodes, and you're my peer.
But you're right, I'll try to be consistent with the other BEPs.
|
|
Thanks, Arvid. Better now? |
|
@arvidn ? |
@arvidn, @ghazel, please review.