Reduce allocations on string operations #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now,
*String
methods are just syntactic sugars for[]byte(str)
conversion; thus, they make unnecessary allocations and copies. This change optimizes string operations not to make any allocations and (data) copies.Below is benchstat result: (it would make bigger improvements on the longer key)
FYI. I didn't use
unsafe.Slice
(introduced in Go 1.17) in this change to support older versions.