Skip to content

Commit

Permalink
Apply YAML lint (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
ofalvai authored Oct 27, 2021
1 parent 3a19333 commit 6427e1e
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 25 deletions.
6 changes: 3 additions & 3 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ workflows:
generate_readme:
steps:
- git::https://github.com/bitrise-steplib/steps-readme-generator.git@main:
inputs:
- contrib_section: docs/contribution.md
- example_section: docs/example.md
inputs:
- contrib_section: docs/contribution.md
- example_section: docs/example.md
17 changes: 10 additions & 7 deletions e2e/bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ workflows:
title: Execute step
# Limit running this test to only one stack to avoid parallel testing issues
# Running E2E tests on all stacks in parallel would cause conflicting deployments in Google Play to the same app
run_if: '{{ or (enveq "IS_LATEST_STACK_UBUNTU" "true") (not .IsCI) }}'
run_if: |-
{{ or (enveq "IS_LATEST_STACK_UBUNTU" "true") (not .IsCI) }}
inputs:
- service_account_json_key_path: $SERVICE_ACCOUNT_KEY_URL
- package_name: $PACKAGE_NAME
Expand Down Expand Up @@ -108,7 +109,7 @@ workflows:
inputs:
- build_gradle_path: ./app/build.gradle
- new_version_code: $BITRISE_BUILD_NUMBER
- new_version_name: "0.2.4"
- new_version_name: 0.2.4
- gradle-runner:
inputs:
- gradle_task: bundleRelease
Expand All @@ -120,14 +121,15 @@ workflows:
title: Execute step
# Limit running this test to only one stack to avoid parallel testing issues
# Running E2E tests on all stacks in parallel would cause conflicting deployments in Google Play to the same app
run_if: '{{ or (enveq "IS_LATEST_STACK_XCODE" "true") (not .IsCI) }}'
run_if: |-
{{ or (enveq "IS_LATEST_STACK_XCODE" "true") (not .IsCI) }}
inputs:
- service_account_json_key_path: $SERVICE_ACCOUNT_KEY_URL
- package_name: $PACKAGE_NAME
- app_path: $BITRISE_SIGNED_AAB_PATH
- track: $TRACK
- user_fraction: 0.6
- release_name: "Overwritten release name"
- release_name: Overwritten release name

test_apk_deploy_custom_track:
summary: Tests deploying an APK to a user-defined track
Expand All @@ -151,7 +153,7 @@ workflows:
inputs:
- build_gradle_path: ./app/build.gradle
- new_version_code: $BITRISE_BUILD_NUMBER
- new_version_name: "0.2.4"
- new_version_name: 0.2.4
- gradle-runner:
inputs:
- gradle_task: assembleRelease
Expand All @@ -163,7 +165,8 @@ workflows:
title: Execute step
# Limit running this test to only one stack to avoid parallel testing issues
# Running E2E tests on all stacks in parallel would cause conflicting deployments in Google Play to the same app
run_if: '{{ or (enveq "IS_LATEST_STACK_UBUNTU" "true") (not .IsCI) }}'
run_if: |-
{{ or (enveq "IS_LATEST_STACK_UBUNTU" "true") (not .IsCI) }}
inputs:
- service_account_json_key_path: $SERVICE_ACCOUNT_KEY_URL
- package_name: $PACKAGE_NAME
Expand All @@ -188,4 +191,4 @@ workflows:
inputs:
- repository_url: $TEST_APP_URL
- clone_into_dir: .
- branch: $BRANCH
- branch: $BRANCH
30 changes: 15 additions & 15 deletions step.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ summary: Upload your Android app to Google Play.
description: |-
The Step uploads your Android app to Google Play. It works with both APK and AAB files.
Please note that in order to successfully use this Step, you must [upload your first APK or AAB file manually](https://support.google.com/googleplay/android-developer/answer/9859152?hl=en&visit_id=637407764704794872-3953166533&rd=1), using Google's own web interface!
Once you uploaded one APK or AAB of your app to Google Play manually, you can use our Step for all subsequent versions.
Please note that in order to successfully use this Step, you must [upload your first APK or AAB file manually](https://support.google.com/googleplay/android-developer/answer/9859152?hl=en&visit_id=637407764704794872-3953166533&rd=1), using Google's own web interface!
Once you uploaded one APK or AAB of your app to Google Play manually, you can use our Step for all subsequent versions.
### Configuring the Step
The Step uses Google's API so before attempting to use the Step, you need to [Set up Google API access](https://devcenter.bitrise.io/deploy/android-deploy/deploying-android-apps/#setting-up-google-play-api-access). This includes:
- [Linking your Google Developer Console to an API project](https://developers.google.com/android-publisher/getting_started#linking_your_api_project).
- [Setting up API access using a service account](https://developers.google.com/android-publisher/getting_started#using_a_service_account).
- Granting the necessary access rights to the service account.
- Upload the service account JSON key to Bitrise and store it in a [Secret Env Var](https://devcenter.bitrise.io/builds/env-vars-secret-env-vars/).
- Granting the necessary access rights to the service account.
- Upload the service account JSON key to Bitrise and store it in a [Secret Env Var](https://devcenter.bitrise.io/builds/env-vars-secret-env-vars/).
Due to the way the Google Play Publisher API works, you have to grant at least the following permissions to that service account:
- Edit store listing, pricing & distribution
Expand All @@ -24,25 +24,25 @@ description: |-
To deploy your app with the Step:
1. In the **Service Account JSON key file path**, add the Secret that stores your service account JSON key.
1. In the **App file path** input, set the path to your APK and/or AAB files. You can add multiple paths here, separated with a newline.
1. In the **Service Account JSON key file path**, add the Secret that stores your service account JSON key.
1. In the **App file path** input, set the path to your APK and/or AAB files. You can add multiple paths here, separated with a newline.
In most cases, the default values work well unless you changed the output variable of the Step that build your APK or AAB.
1. In the **Package name** input, set the package name of your app.
1. In the **Package name** input, set the package name of your app.
1. In the **Track** input, add the track to which you want to assign the app. This can be any of the built-in tracks or a custom track of your own.
### Troubleshooting
### Troubleshooting
If the Step fails, check the following:
- If it's an authentication error, check that your Secret points to the correct file (and that a file is uploaded at all).
- If it's an authentication error, check that your Secret points to the correct file (and that a file is uploaded at all).
- Make sure your service account has the necessary access rights.
- Check that there's no typo in the package name and that you selected an existing track for the app.
- Check that there's no typo in the package name and that you selected an existing track for the app.
### Useful links
### Useful links
- [Google Play Developer API - Getting Started](https://developers.google.com/android-publisher/getting_started)
- [Deploying Android apps](https://devcenter.bitrise.io/deploy/android-deploy/deploying-android-apps/)
### Related Steps
### Related Steps
- [TestFairy Deploy Android](https://www.bitrise.io/integrations/steps/testfairy-deploy-android)
- [AppCenter Android Deploy](https://www.bitrise.io/integrations/steps/appcenter-deploy-android)
Expand Down Expand Up @@ -140,7 +140,7 @@ inputs:
is_required: false
- whatsnews_dir:
opts:
title: "Directory of localized what's new files"
title: Directory of localized what's new files
description: |-
Use this input to specify localized 'what's new' files directory.
This directory should contain 'whatsnew' files postfixed with the locale.
Expand All @@ -157,12 +157,12 @@ inputs:
Format examples:
- "./" # what's new files are in the repo root directory
- "./whatsnew" # what's new files are in the whatsnew directory
- mapping_file: "$BITRISE_MAPPING_PATH"
- mapping_file: $BITRISE_MAPPING_PATH
opts:
title: Mapping txt file path
description: |-
The `mapping.txt` file provides a translation between the original and obfuscated class, method, and field names.
Uploading a mapping file is not required when deploying an AAB as the app bundle contains the mapping file itself.
In case of deploying [multiple artifacts](https://developer.android.com/google/play/publishing/multiple-apks.html), you can specify multiple mapping.txt files as a newline (`\n`) or pipe (`|`) separated list. The order of mapping files should match the list of APK or AAB files in the `app_path` input.
Expand Down

0 comments on commit 6427e1e

Please sign in to comment.